• 0 Posts
  • 12 Comments
Joined 3 years ago
cake
Cake day: October 4th, 2023

help-circle
  • You could submit a PR for each bug or if there are a few bugs around the same thing then bundling those up is fine. You could have been submitting PRs every couple hours to a day for that month.

    These have a lot of potential for abuse so use with caution but things that have dependencies on each other can use stacked PRs(yeah, this is GitHub specific). I’ve also found that splitting out any generated code with these is tremendously helpful at review time. Not talking about AI generated code. An example would be something like using a client generator for an OpenApi document. That way the tens to hundreds of files from the generator are in their own layer of the stacked PR and all the logic that uses it is in the other. You review each layer individually and can spend significantly less time on the generated one.

    Don’t feel bad especially if it was your first time. This is my largest PR ever. It was just removing old projects from a repo though that were triggering our security/vulnerability scanning though.


  • I honestly wish for a PR this size. One of the ones that came across this week was 813 commits, +17K -2K.

    Of the 250 commits that GitHub was willing to show it had 35 other PRs merged into this massive one. Why they thought one giant PR was somehow better I’ll never know.

    Of course…high priority, please review and merge immediately. Like guys it’s gonna take me a week to make sense of this.







  • My understanding is that the testing methods have diverged enough that very few helmets meet both the ECE 22.06 and DOT(FMVSS 218) certifications. A European helmet with only the ECE certification would not be ‘street legal’ here in the states. I own a Shoei RF-1400 with a Snell/DOT rating. I believe the EU sells it as the NXR2 (with only ECE 22.06) but while they look identical they have tiny differences for the certifications they need to pass. I think the ECE 22.06 standard is better than the DOT one by far and I wish the US would just conform with most of the world but we don’t really do that. The major problem helmets are generally not from big name manufacturers but the hundreds of ‘DOT certified’ helmets you can find on Amazon for $30-100 from brands like GIDLVV and other such gibberish. You can basically guarantee those are absolute junk but they come with the correct sticker…