[Rust + Tauri + React] Cryptography Usage Review

gitlab.com

[Rust + Tauri + React] Cryptography Usage Review

gitlab.com

tengkuizdihar to

Code Review@programming.devEnglish · 1 year ago

src-tauri/src/app/crypto.rs · master · treedome / treedome · GitLab

gitlab.com

A local-first, encrypted, note taking application with tree-like structures, all written and saved in your computer.

I’m making an offline first, note taking application made with rust+tauri. I’ve reviewed this before with one of my friend and he checks everything from the way I use the library, how I uses my nonces, salt, and the like. But It’s never a bad thing to ask you guys for some thought, if any.

Please take it slow, assume the best, and be gentle with me.

Chat

tengkuizdiharOP
link
fedilink
arrow-up
1·
1 year ago
I’m just going to move on from discuss.social… somehow programming.dev is a lot faster when federating these days. Can be logged into too from jerboa!

Code Review@programming.dev

code_review@programming.dev

Create a post

You are not logged in. However you can subscribe from another Fediverse account, for example Lemmy or Mastodon. To do this, paste the following into the search field of your instance: !code_review@programming.dev

Welcome to the programming.dev code review community! This is a place where you can review other people’s code or request reviews on your own

Before posting please read the sections below (click on one to expand it)

What is a code review?

A code review is a process where people who did not write a piece of code look over it to find errors, suggest improvements, and make sure it follows coding standards

When doing a code review look for these aspects:

Correctness: Does the code behave as expected and meet the requirements?
Readability: Is the code easy to understand and maintain?
Efficiency: Are there more efficient ways to accomplish the same task?
Best Practices: Does the code follow established coding standards and best practices?
Security: Are there potential security vulnerabilities?
Scalability: Will the code perform well as the application scales?

Post Guidelines

Guidelines

Put the programming language you used for your code in square brackets ahead of your post title. e.g. [Python], [React], [C#], etc.
Provide a link to a spot where people can view your code (e.g. github, etc.) in your post body
In your post title put a small description of what the thing is that you want reviewed and then you can expand on that in more details if you want in your post body

Rules

Any code review requests you post after your first must be done after you have reviewed two other people’s code (and then you need another two for each request after that as well).

Youre free to post your first code review request in this community though without needing to follow this

Credits

Icon base by Lorc under CC BY 3.0 with modifications to add a gradient

Wormhole

!react@programming.dev

Visibility: Public

This community can be federated to other instances and be posted/commented in by their users.

1 user / day
1 user / week
1 user / month
1 user / 6 months
1 local subscriber
155 subscribers
5 Posts
22 Comments
Modlog

mods:
Vacant@programming.dev