• Omega_Jimes@lemmy.ca
    link
    fedilink
    arrow-up
    71
    arrow-down
    2
    ·
    12 days ago

    I’m not great at English, but “discard all changes” shouldn’t ever mean “Delete”.

    • Michal@programming.dev
      link
      fedilink
      arrow-up
      40
      arrow-down
      9
      ·
      12 days ago

      In the context of version control it does. Discarding a change that creates a file means deleting the file.

      • thebestaquaman@lemmy.world
        link
        fedilink
        arrow-up
        15
        ·
        12 days ago

        If you have set up your staging area for a commit you may want to discard (unstage) changes from the staging area, as opposed to discarding changes in the working directory.

        Of course, the difference between the two is obvious if you’re using git CLI, but I can easily see someone using a GUI (and that maybe isn’t too familiar with git) misunderstanding “discard” as “unstage”.

        Either way, what happened here indicates that all the files were somehow added to the VC, without having been committed first, or something like that, because git will not let you discard a file that is untracked, because that wouldn’t make any sense. The fact that the GUI let this person delete a bunch of files without first committing them to the index is what makes this a terrible design choice, and also what makes the use of the word “discard” misleading.

      • Omega_Jimes@lemmy.ca
        link
        fedilink
        arrow-up
        3
        arrow-down
        1
        ·
        12 days ago

        Ok fair enough, but I’m under the impression these files existed before the source control was implemented.

        I guess it’s all up to how the program handles existing files.

        • FiskFisk33@startrek.website
          link
          fedilink
          arrow-up
          4
          ·
          12 days ago

          I guess the newly created git repository was empty, and all the files that was present in the folder represented “changes”

    • stebo@lemmy.dbzer0.com
      link
      fedilink
      arrow-up
      7
      arrow-down
      2
      ·
      12 days ago

      I’m pretty sure vscode shows a confirmation dialog when discarding changes will permanently delete a file. I’ve done that recently with temporary files that were no longer needed.

    • stebo@lemmy.dbzer0.com
      link
      fedilink
      arrow-up
      4
      arrow-down
      1
      ·
      12 days ago

      the alternative to deleting is emptying the file contents, which is essentially the same…